Upgrade Azure SDK BOM to 1.3.6 and pin msal4j 1.24.1 for sovereign cl…#475
Merged
Merged
Conversation
…oud support (#472) * Initial plan * Upgrade azure-bom-version and pin msal4j 1.24.1 for sovereign cloud support Agent-Logs-Url: https://github.com/Azure/azure-kusto-java/sessions/69c6016a-46bc-4de9-a13a-e0fec18afb26 Co-authored-by: tanmaya-panda1 <108695755+tanmaya-panda1@users.noreply.github.com> * Address review comments: pin msal4j in quickstart, drop redundant BOM override in ingest-v2 - quickstart/pom.xml: add msal4j 1.24.1 dependencyManagement pin since this module is standalone (no parent) and would otherwise resolve an older transitive msal4j via azure-identity, undermining the sovereign-cloud fix. - ingest-v2/pom.xml: remove redundant azure-bom-version override; the property is now inherited from the root parent (also 1.3.6), avoiding future drift. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Restore explicit azure-bom-version 1.3.6 in ingest-v2/pom.xml for clarity Agent-Logs-Url: https://github.com/Azure/azure-kusto-java/sessions/d58014b1-c88c-47d1-b610-0cff08d64b6d Co-authored-by: tanmaya-panda1 <108695755+tanmaya-panda1@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tanmaya-panda1 <108695755+tanmaya-panda1@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Test Results537 tests 528 ✅ 9m 30s ⏱️ Results for commit b7c7cd0. ♻️ This comment has been updated with latest results. |
tanmaya-panda1
approved these changes
May 6, 2026
There was a problem hiding this comment.
Pull request overview
Updates Maven dependency management to align the project with newer Azure SDK versions and to pin msal4j to a specific version (notably for sovereign cloud compatibility scenarios).
Changes:
- Bumped the Azure SDK BOM property from
1.2.28to1.3.6in the rootpom.xml. - Introduced centralized version management for
com.microsoft.azure:msal4j(property +dependencyManagement) in the rootpom.xml. - Added
msal4jversion management inquickstart/pom.xml, alongside a new (currently unused)azure-identity.versionproperty.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pom.xml |
Upgrades Azure BOM property and adds root-level dependencyManagement entry to pin msal4j. |
quickstart/pom.xml |
Adds properties and a dependencyManagement entry to pin msal4j for the standalone quickstart module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <maven-assembly-plugin.version>3.3.0</maven-assembly-plugin.version> | ||
| <slf4j.version>1.8.0-beta4</slf4j.version> | ||
| <json.version>20201115</json.version> | ||
| <azure-identity.version>1.18.2</azure-identity.version> |
| <version>${msal4j.version}</version> | ||
| </dependency> | ||
| </dependencies> | ||
| </dependencyManagement> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates dependency management for Azure libraries and introduces the
msal4jlibrary across the project. The main changes include upgrading the Azure BOM version, adding and managing themsal4jdependency, and aligning versions in both the root andquickstartmodulepom.xmlfiles.Dependency upgrades and additions:
azure-bom-versionfrom1.2.28to1.3.6in the rootpom.xml, ensuring newer Azure SDK versions are used.msal4j.versionproperty and set it to1.24.1in both the root andquickstart/pom.xmlfiles for consistent version management. [1] [2]azure-identity.versionproperty set to1.18.2inquickstart/pom.xmlto facilitate Azure authentication features.Dependency management configuration:
dependencyManagementsection in the rootpom.xmlto centrally manage themsal4jdependency version for all modules.msal4jdependency to thedependencyManagementsection inquickstart/pom.xmlto ensure consistent usage within the module.Added
Changed
Fixed