Skip to content

Remove EUII from x-ms-app #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yihezkel wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove EUII from x-ms-app #395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bb08ea
Remove EUII from x-ms-app
yihezkel Mar 18, 2026
b77b00c
Add missing dependency
yihezkel Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/azure-kusto-data/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"browser": {
"fs": false,
"os": false,
"path": false,
"process": false,
"stream-http": false,
"https": false,
Expand Down
5 changes: 4 additions & 1 deletion packages/azure-kusto-data/src/clientDetails.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

import { isNodeLike } from "@azure/core-util";
import { userInfo } from "os";
import { basename } from "path";
import { SDK_VERSION } from "./version.js";

// eslint-disable-next-line @typescript-eslint/no-namespace,@typescript-eslint/no-unused-vars -- This is the correct way to augment the global namespace
Expand Down Expand Up @@ -36,7 +37,9 @@ export class ClientDetails {

static defaultApplication(): string {
if (isNodeLike) {
return process?.env?.npm_package_name || process?.argv[1] || None;
// Use only the base filename from argv[1] to avoid leaking the full
// filesystem path (which may contain the username).
return process?.env?.npm_package_name || (process?.argv?.[1] ? basename(process.argv[1]) : None);
Comment on lines +40 to +42
} else {
return window?.location?.href || None;
}
Expand Down
Loading