-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Node interop: Add handling for redirect URI based on platform #7939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements platform-specific redirect URI handling for the native broker plugin in the MSAL Node Extensions library. The change enables the broker to use appropriate redirect URIs based on the operating system platform.
- Adds a new private method
chooseRedirectUriByPlatform
that returns platform-specific redirect URIs - Updates both
acquireTokenSilent
andacquireTokenInteractive
methods to use platform-specific redirect URIs - Removes the msal-node-extensions sample application directory and files
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 6 comments.
File | Description |
---|---|
extensions/msal-node-extensions/src/broker/NativeBrokerPlugin.ts |
Implements platform-specific redirect URI logic and refactors token acquisition methods |
extensions/msal-node-extensions/test/broker/NativeBrokerPlugin.spec.ts |
Adds comprehensive test coverage for redirect URI handling across all platforms |
extensions/samples/msal-node-extensions/* |
Removes sample application files (package.json, index.js, CHANGELOG.json, .npmrc, .beachballrc) |
82e7910
v5 version of #7908