Skip to content

Conversation

shylasummers
Copy link
Contributor

v5 version of #7908

@Copilot Copilot AI review requested due to automatic review settings July 22, 2025 16:57
@github-actions github-actions bot added the extensions Related to extensions for the base libraries label Jul 22, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements platform-specific redirect URI handling for the native broker plugin in the MSAL Node Extensions library. The change enables the broker to use appropriate redirect URIs based on the operating system platform.

  • Adds a new private method chooseRedirectUriByPlatform that returns platform-specific redirect URIs
  • Updates both acquireTokenSilent and acquireTokenInteractive methods to use platform-specific redirect URIs
  • Removes the msal-node-extensions sample application directory and files

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 6 comments.

File Description
extensions/msal-node-extensions/src/broker/NativeBrokerPlugin.ts Implements platform-specific redirect URI logic and refactors token acquisition methods
extensions/msal-node-extensions/test/broker/NativeBrokerPlugin.spec.ts Adds comprehensive test coverage for redirect URI handling across all platforms
extensions/samples/msal-node-extensions/* Removes sample application files (package.json, index.js, CHANGELOG.json, .npmrc, .beachballrc)

hectormmg
hectormmg previously approved these changes Jul 22, 2025
@shylasummers shylasummers enabled auto-merge (squash) July 22, 2025 17:01
peterzenz
peterzenz previously approved these changes Jul 22, 2025
@shylasummers shylasummers merged commit 61101e9 into msal-v5 Aug 11, 2025
7 checks passed
@shylasummers shylasummers deleted the nodeInteropV5 branch August 11, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensions Related to extensions for the base libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants