-
Notifications
You must be signed in to change notification settings - Fork 2.7k
(v5) bugfix get native account #8105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: msal-v5
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug in the native account retrieval logic by adding validation for empty or invalid account filters. When no login hint or SID is provided, the code now properly falls back to using the active account's native account ID instead of attempting to filter with invalid criteria.
Key changes:
- Added validation in
CacheManager.getAccountInfoFilteredByto detect and handle empty/invalid account filters - Removed redundant filter validation from
AccountManager.getAccountsince it's now handled at the cache layer - Added test coverage for the new validation logic
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/msal-common/src/cache/CacheManager.ts | Added validation to return null and log a warning when account filter is empty or contains only falsy values |
| lib/msal-common/test/cache/CacheManager.spec.ts | Added test case verifying null is returned when filter has empty string values |
| lib/msal-browser/src/cache/AccountManager.ts | Removed duplicate empty filter check and simplified logging |
| lib/msal-browser/test/cache/BrowserCacheManager.spec.ts | Added test case verifying null is returned when filter has undefined values |
Co-authored-by: Copilot <[email protected]>
…AD/microsoft-authentication-library-for-js into v5_bugfix_getNativeAccount
|
This looks like it changes the behavior of the API, is this intended? |
|
Reminder: This PR appears to be stale. If this PR is still a work in progress please mark as draft. |
v5 PR for the getNativeAccountId bug fix (#7960)