fix(io): re-point FfbForwarder at the fresh fd on device rebind - #464
Conversation
FfbForwarder captures devices[0]'s hidraw fd by value at init. On a sleep/wake rebind, closeDeviceIO closes the old fd and rebindDeviceIO swaps in a new one, but the forwarder kept the stale fd — so after resume it wrote PID FFB reports to a closed (or recycled) fd, either silently disabling rumble or writing to the wrong file. Add FfbForwarder.setPhysicalFd and call it from rebindDeviceIO to re-point at the new devices[0] fd (and re-arm a self-disabled forwarder). Only affects force_feedback backend="uhid" kind="pid" wheels.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
Warning Review limit reached
Next review available in: 24 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Bug
FfbForwardercapturesdevices[0]'s hidraw fd by value at init. On a sleep/wake rebind,closeDeviceIOcloses the old fd andrebindDeviceIOswaps in a new one, but the forwarder kept the stale fd. After resume it wrote PID FFB reports to a closed (→ EBADF, forwarder permanently disabled) or recycled fd (→ wrong file). Only affectsforce_feedback backend="uhid" kind="pid"wheels that suspend/resume.Fix
Add
FfbForwarder.setPhysicalFdand call it fromrebindDeviceIOto re-point at the newdevices[0]fd, re-arming a forwarder that may have disabled itself on the stale fd.Test plan
DeviceInstance: rebindDeviceIO re-points FfbForwarder at the fresh fd. Verified red→green: it fails on the unfixed code (physical_fdstuck on the old fd) and passes after the re-point.zig build test, exit 0).