fix: added authorization for admins to remove resources from negotiation - #1237
Open
ChrisiSailer wants to merge 1 commit into
Open
fix: added authorization for admins to remove resources from negotiation#1237ChrisiSailer wants to merge 1 commit into
ChrisiSailer wants to merge 1 commit into
Conversation
|
|
stetsche
requested changes
Jul 21, 2026
|
|
||
| private void verifyRemoveResourcePreconditions(String negotiationId, Negotiation negotiation) { | ||
| if (!isNegotiationCreator(negotiationId)) { | ||
| if (!isNegotiationCreator(negotiationId) |
Collaborator
There was a problem hiding this comment.
We might need to queue the PR, but would be nice to use isNegotiationEditor here as well. 1) to have it defined in one place and 2) so collaborators can remove resources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Admins now have the proper authorization to remove resources from a negotiation which they do not own.
Checklist:
Make sure you tick all the boxes below if they are true or do not apply before you ask for review
Required for all pull requests:
If applicable to this PR: