Fix N+1 query in PayloadIOVBulkCreationAPIView - #97
Open
VincenzoImp wants to merge 1 commit into
Open
Conversation
PayloadList.objects.get() was called inside the list comprehension, executing one query per item in the batch. Pre-fetch all needed PayloadList objects in a single query using filter(name__in=...). Also adds explicit validation for missing PayloadList names, returning 400 instead of letting DoesNotExist bubble up as 500.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66.
Recreates #67, which was auto-closed when the
masterbranch was deleted during the migration tomain. The change is rebased onto currentmain, where the bulk-create endpoint still issues onePayloadList.objects.get()per input row.This resolves all referenced PayloadLists in a single
filter(name__in=...)query and reports missing ones with a 400 response listing their names, instead of an unhandledDoesNotExist(HTTP 500) on the first missing entry.Django CI passes on this branch.