Pokemon Pinball: Fix Coordinate System interpretaion#387
Pokemon Pinball: Fix Coordinate System interpretaion#387NicoleFaye wants to merge 4 commits intoBaekalfen:masterfrom
Conversation
I think it includes both commits from the other day. And then you have a merge commit. Might be because you're basing it off of your existing branch. A quick way to fix it, is to take note of the sha ( |
|
Okay i think its good now, lmk what you think of the param defaults, wasnt sure if it should have them or not |
pyboy/utils.py
Outdated
| """ | ||
| value = int.from_bytes(raw_bytes, "little") | ||
|
|
||
| total_bits = num_bytes * 8 |
There was a problem hiding this comment.
Can't you deduce the num_bytes from the length of raw_bytes?
There was a problem hiding this comment.
yes you absolutely can, i think ive been writing too much c lately. ill fix it in the morning, i thnk i still have 1 other small edit i wanna work in this pr, going to make it a draft for now i think
|
i think making this a draft ran some of the github actions? you might want to check if thats intended behavior |
Convert Incorrect integer interpretation to correct 8.8 fixed point decimal interpretation.
Originally misunderstood the way the coordinates are represented causing invalid coordinates to be displayed.
Added helper util method to convert from fixed point to float.
Reviewed all other ram accessed var value interpretations and all others seem to be correct.