add missing includes #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several includes are missing based on linux man pages: - strings.h for strcasecmp - alloca.h for alloca - stdio.h for fileno The compilation with GCC 15 fails without those with implicit function declaration error.
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Mar 3, 2025
- add missing includes and append -D_POSIX_SOURCE cppflag in order to resolve implicit function declaration issues - set -std=c17 because upstream typedefs bool in code base Upstream-PR: Baron-von-Riedesel/JWasm#34 Closes: https://bugs.gentoo.org/944893 Signed-off-by: Petr Vaněk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several includes are missing based on linux man pages:
strcasecmpallocafilenoThe compilation with GCC 15 fails without those with implicit function declaration error.
It is also worth to say that GCC 15 defaults to
-std=c23, whereboolis a reserved keyword, thus GCC produces following error:I am using
-std=c17for now.