Feature/168 browser web push - #456
Merged
thisismeonmounteverest merged 12 commits intoJul 28, 2026
Merged
Conversation
…eb-push # Conflicts: # translations/missing/preference.yaml
Validate endpoint ownership and VAPID configuration, make migrations and queue leases safe, and reconcile subscriptions across preference and logout transitions. Align retention, member exports, privacy copy, and regression coverage with the stored push data. Refs BeWelcome#168
| arguments: | ||
| $batchSize: '%forum_notification_batch_size%' | ||
|
|
||
| App\Service\PushGatewayInterface: '@App\Service\PushGateway' |
Contributor
There was a problem hiding this comment.
These interfaces aren't used anywhere, are they?
Contributor
Author
There was a problem hiding this comment.
They are used as autowiring contracts: PushGatewayInterface is injected into BrowserNotificationService, BrowserPushEndpointResolverInterface into BrowserPushEndpointValidator, and BrowserPushWebPushFactoryInterface into PushGateway
Contributor
There was a problem hiding this comment.
If the interface is just the class why not use the class instead?
Contributor
There was a problem hiding this comment.
But I merge it anyway would like to see it in action :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.