Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR represents my combing through the descriptions within the TRAPI spec and outside it in the implementation guidance, and checking off the last few inconsistencies.
Primarily, this involves a refactor of the Operation system to be able to more thoroughly check and report MetaAttribute support of both QEdges and QNodes.
Additionally, unknown fields on QNodes/QEdges now produce warnings, and the validation methods have been refactored to handle the difference between warnings and errors.
The only thing left out is
bypass_cachehandling, as it's not particularly feasible as of yet. It's not in keeping nor useful to force a bypass of the Operation cache, and it's unworth dev time in the face of present priorities to implement transpiler/driver-level cache bypass for backend access. So, this will be left to the future.