Skip to content

Conversation

@shuchenliu
Copy link
Contributor

Add Tier 1 transpiler logic and associated driver class for generating Elasticsearch query payloads for given TRAPI queries.

@tokebe tokebe closed this Sep 3, 2025
@tokebe tokebe reopened this Sep 3, 2025
@codecov
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 8.52713% with 118 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...etriever/data_tiers/tier_1/elasticsearch/driver.py 0.00% 78 Missing ⚠️
...ever/data_tiers/tier_1/elasticsearch/transpiler.py 0.00% 40 Missing ⚠️
Files with missing lines Coverage Δ
src/retriever/config/general.py 100.00% <100.00%> (ø)
...ever/data_tiers/tier_1/elasticsearch/transpiler.py 0.00% <0.00%> (ø)
...etriever/data_tiers/tier_1/elasticsearch/driver.py 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tokebe tokebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good-- I've made a few notes, and you've got a few complaints from the github actions (sorry for not having those set up right prior).

You'll want to make sure to commit the lockfile when adding dependencies. Also, to shortcut waiting on actions to see if you've upset the type checker/etc., I'd recommend running task fixup in the workspace to see what the linter/type checker/etc. have to say. You can also run task hook to make it so these run automatically and must pass when making a commit.

Codecov is complaining, as well. For the sake of time, don't worry about writing tests right now, but if you have time in the future please do add tests if you can.

@shuchenliu shuchenliu requested a review from tokebe September 4, 2025 02:31
@shuchenliu
Copy link
Contributor Author

All suggested code changes were applied. Test coverage will definitely be addressed in future iterations.

@tokebe
Copy link
Contributor

tokebe commented Sep 4, 2025

The PR still has problems-- linting and typechecking have pointed out errors that would cause runtime failures (request_timeout vs query_timeout in the config, etc.)

For the sake of time, I've pulled your PR into a branch and am fixing it, but in the future you'll want to make sure you're using ruff and basedpyright in your editor as they're set up for the workspace, or running task fixup in the workspace commandline, so you can catch these kinds of problems early.

@tokebe tokebe merged commit ba3cda3 into BioPack-team:main Sep 5, 2025
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants