[Paused] Enable ODBC build in macOS Intel CI #138
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justing-bq
force-pushed
the
apache-odbc
branch
from
2575182 to
2671b6d
Compare
alinaliBQ
force-pushed
the
enable-macos-ci
branch
from
36282dd to
fb25307
Compare
justing-bq
force-pushed
the
apache-odbc
branch
2 times, most recently
from
e6dfb52 to
7df62c8
Compare
TEMP - disable Windows CI to reduce work load
macOS 14 is on ARM. ODBC cannot build on ARM mac 14 yet.
alinaliBQ
force-pushed
the
enable-macos-ci
branch
from
fb25307 to
ccc79ef
Compare
Updated readme. The build works locally on my Intel mac machine.
alinaliBQ
force-pushed
the
enable-macos-ci
branch
from
8b38903 to
da2e4f5
Compare
On macOS, sqltypes.h defines `BOOL` which causes a conflict on macOS
alinaliBQ
changed the title
This reverts commit de22953.
Add explicit `undef` commands in .cc files where `type::BOOL` is used.
Move include of odbc_impl header to after utf8.
alinaliBQ
force-pushed
the
enable-macos-ci
branch
from
9bbdae7 to
b73c118
Compare
Push local changes for a copy online, will likely remove the script from this PR later.
unixodbc is not needed for building ODBC.
Use command to find actual libiodbc path
Getting errors
```
In file included from /usr/local/include/sqlucode.h:784:
/usr/local/include/sqlext.h:1790:19: error: conflicting types for 'SQLDriverConnectW'
1790 | SQLRETURN SQL_API SQLDriverConnect(
| ^
/usr/local/include/sqlucode.h:765:26: note: expanded from macro 'SQLDriverConnect'
765 | #define SQLDriverConnect SQLDriverConnectW
| ^
/usr/local/include/sqlucode.h:257:19: note: previous declaration is here
257 | SQLRETURN SQL_API SQLDriverConnectW(
| ^
```
trying to see if switching to ARM macOS will fix the issue.
alinaliBQ
force-pushed
the
enable-macos-ci
branch
from
9fece32 to
d677087
Compare
alinaliBQ
force-pushed
the
enable-macos-ci
branch
from
4375cc9 to
421aa00
Compare
alinaliBQ
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Flight SQL ODBC build in macOS CI. Note that Flight SQL is also enabled as a result.