-
Couldn't load subscription status.
- Fork 109
frontend: cleanup css #3647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: cleanup css #3647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One typo - otherwise looks good!
|
|
||
| .animationAndTextContainer p { | ||
| font-size: var(--header-default-font-size); | ||
| font-size: var(--size-headere); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo! :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for catching this. fixedup into "frontend: rename css variable" commit and force pushed
Renamed --size-header to be more consistent with other names.
--size-large-mobile was only used on mobile for the balance amount. Chagned to closest available value which is --size-header. This is not exactly the same as 1.4rem (22.4px) however 22.4px is not a font-size that is used anywhere else. With this change the account view now has same font-size for header as well as balance.
Was only used during setup for the label of the name input field and the backup checklist for the checkboxes. In both views there is no reason to use another font-size, without it the text looks more consistent and label, input field and error message have the same font-size as in other palces.
5f8bad4 to
e9bc75c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!




In preparation for #3623