Skip to content

Conversation

@thisconnect
Copy link
Collaborator

@thisconnect thisconnect commented Oct 24, 2025

In preparation for #3623

@thisconnect thisconnect changed the title Frontend cleanup css frontend: cleanup css Oct 24, 2025
@thisconnect
Copy link
Collaborator Author

last 2 commits slightly change the layout, see commit message.

Here are some screenshots how it looks with this change:

Screenshot 2025-10-24 at 14 50 10 Screenshot 2025-10-24 at 14 50 16 Screenshot 2025-10-24 at 14 47 29 Screenshot 2025-10-24 at 14 47 10

@thisconnect thisconnect marked this pull request as ready for review October 24, 2025 13:40
Copy link
Collaborator

@shonsirsha shonsirsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo - otherwise looks good!


.animationAndTextContainer p {
font-size: var(--header-default-font-size);
font-size: var(--size-headere);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo! :-)

Copy link
Collaborator Author

@thisconnect thisconnect Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching this. fixedup into "frontend: rename css variable" commit and force pushed

Renamed --size-header to be more consistent with other names.
--size-large-mobile was only used on mobile for the balance amount.

Chagned to closest available value which is --size-header. This is
not exactly the same as 1.4rem (22.4px) however 22.4px is not a
font-size that is used anywhere else. With this change the account
view now has same font-size for header as well as balance.
Was only used during setup for the label of the name input field
and the backup checklist for the checkboxes.

In both views there is no reason to use another font-size, without
it the text looks more consistent and label, input field and error
message have the same font-size as in other palces.
Copy link
Collaborator

@shonsirsha shonsirsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@thisconnect thisconnect merged commit 5e639f7 into BitBoxSwiss:master Oct 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants