Skip to content

Conversation

@sigjhl
Copy link
Contributor

@sigjhl sigjhl commented Jan 15, 2026

WARNING! This is my first PR sorry if it's crappy.
I've gotta come clean here; Antigravity did everything, but I made sure it works !

This PR adds support for Google's MedASR model (Lasr architecture).

Changes:

  • Added mlx_audio/stt/models/lasr/ implementation (LasrEncoder, LasrForCTC).
  • Updated utils.py to support lasr_ctc model type.
  • Updated utils.py: Added fallback to mapped model type in get_model_class to correctly resolve lasr_ctc -> lasr when model name doesn't match a directory.
  • Added example usage script: examples/medasr_transcribe.py.

Verification:

  • Verified weight conversion from google/medasr.
  • Verified inference on sample audio matches expected transcription.
  • Verified MPS support.

Jeonghyun Lee added 3 commits January 15, 2026 17:57
This commit adds full support for the MedASR model (Lasr architecture) to mlx-audio.

Changes:
- Added  implementation (LasrEncoder, LasrForCTC).
- Updated  and  to support  model type.
- Fixed model loading logic in  to correctly handle mapped model types.
- Added  for weight conversion from Hugging Face.
- Added examples:
  - : File-based transcription.
  - : Live transcription with TEN-VAD and ring buffer.
Copy link
Owner

@Blaizzy Blaizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sigjhl

Awesome work, Medical ASR is of much interest, for a first PR this good!

A few comments.

  • We don't use mps or torch, it's purely mlx inferencing.
  • You can use past PRs as base to learn from or guide your coding agent #320

Just address these comments and we will be in good place to merge

@sigjhl
Copy link
Contributor Author

sigjhl commented Jan 19, 2026

Thanks for the feedback, King!

The torch and mps in the example scripts was to roughly compare the speed gain with mlx; I've removed them from the example scripts.
I've also added the unit tests for MedASR (mimicking GLM-ASR tests).

@sigjhl
Copy link
Contributor Author

sigjhl commented Jan 20, 2026

I removed another unnecessary file and recommitted. Sorry for the mess.

@sigjhl sigjhl requested a review from Blaizzy January 26, 2026 08:30
Copy link
Owner

@Blaizzy Blaizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. A few final nits and we are ready to merge.

@sigjhl sigjhl requested a review from Blaizzy January 27, 2026 07:07
Copy link
Owner

@Blaizzy Blaizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Blaizzy Blaizzy merged commit 2ba7e2a into Blaizzy:main Feb 2, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants