Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
What
Adds ColQwen3 (Tomoro
tomoro-colqwen3-embed-8b) support to mlx-vlm for multimodal retrieval embeddings.Why
Tomoro ColQwen3 is a ColBERT-style multi-vector embedding model on top of a Qwen3-VL backbone.
Without native support, MLX users cannot convert/load the checkpoint or produce token-level embeddings.
Changes
colqwen3model type integration for convert/loadembedding_proj_layerandencode()to output token-level embeddings[B,T,D]encode_queries(processor, texts)encode_images(processor, images)(returns visual-token embeddings; ideal for PDF patches)maxsim(q, d)for ColBERT MaxSim scoringvlm.model.*→vlm.*)Testing
load(<HF repo>, trust_remote_code=True)worksNotes
This PR focuses on embedding usage, not generation. No changes to public generation APIs expected.