fix(cicd): label build artifacts as dank-mids outputs#1048
fix(cicd): label build artifacts as dank-mids outputs#1048BobTheBuidler wants to merge 5 commits intomasterfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29adb2932c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
.github/workflows/build.yaml
Outdated
| include: | ||
| - os: ubuntu-latest | ||
| artifact_suffix: linux | ||
| artifact_glob: "**/*.so" |
There was a problem hiding this comment.
Specify python-version in matrix include entries
The matrix.include entries only set os plus the artifact fields, but they omit python-version. In GitHub Actions, include data is only merged into a matrix job when it matches an existing combination, so these entries won’t apply to the 15 os+python-version jobs. That leaves matrix.artifact_suffix/matrix.artifact_glob empty in the upload step, producing artifact names like dank-mids--artifacts-3.10 and paths without the glob; the downstream download patterns (dank-mids-macos-artifacts-*, etc.) won’t match those names, so the finalize job will miss compiled binaries. Add python-version to each include row (or use a mapping expression) so every matrix combination gets the suffix/glob.
Useful? React with 👍 / 👎.
Motivation
dank-midslibrary (which vendorsaiolimiter), so artifact names and download patterns should referencedank-midsrather than the vendored package.Description
.github/workflows/build.yamlfromaiolimiter-*todank-mids-*and updated the Linux C/H artifact name todank-mids-linux-c-headers.dank_mids/_vendor/aiolimiter/src/so the build still collects the vendored extension outputs.Testing
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 pytest, which errored during collection due to a missing external executable (ganache-cli), so compiled-extension verification could not be completed.Codex Task