fix: restore import side effects and eth alias behavior

[BobTheBuidler]

Summary

• Restore import-time side effects for dank_mids and dank_mids.helpers while keeping helper symbols lazy.
• Guard eth/web3 alias resolution when the dank_mids.eth submodule is imported first.
• Update lazy-import tests to assert immediate side effects and alias behavior.

Rationale

• Pre-refactor: make dank_mids import lazy #1070/refactor: defer helper side effects until setup access #1071 UX relied on import-time side effects and dank_mids.eth always resolving to the instance (or raising BrownieNotConnectedError).
• Keeping helper imports lazy avoids pulling heavy optional deps while restoring the expected user-visible behavior.

Details

• Call _ensure_side_effects() at module import in dank_mids/__init__.py and dank_mids/helpers/__init__.py.
• Install a module alias guard to re-resolve eth/web3 when submodule shadowing occurs.
• Restore the parent dank_mids.eth alias when dank_mids.eth loads.
• Tests: PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 pytest tests/unit/test_lazy_imports.py.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 298951bb57

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Avoid resolving eth while cleaning up failed alias restore

When dank_mids.eth is imported in an environment where dank_mids.dank_eth cannot be resolved (e.g., Brownie not connected), this getattr(parent, "eth", None) call triggers the module alias guard in dank_mids.__init__, which re-enters lazy alias resolution and raises BrownieNotConnectedError. That exception escapes _restore_eth_alias() and makes import dank_mids.eth fail, even though the submodule itself is otherwise importable. The cleanup path should read the raw module dict (or catch this access) instead of invoking attribute resolution again.

Useful? React with 👍 / 👎.

[BobTheBuidler]

Good catch — fixed by reading parent.__dict__ directly so alias cleanup no longer triggers lazy resolution. Updated in 53fc78d and tests still pass.