Skip to content

fix: SytemError in Semaphore init if subclassed in extension module #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BobTheBuidler wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: SytemError in Semaphore init if subclassed in extension module #685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc85ec0
fix: SytemError in Semaphore init if subclassed in extension module
BobTheBuidler Apr 24, 2025
bf1eda9
fix: UnboundLocalError
BobTheBuidler Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion a_sync/primitives/locks/semaphore.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,16 @@ cdef class Semaphore(_DebugDaemonMixin):
) from e.__cause__

# we need a constant to coerce to char*
cdef bytes encoded_name = (name or getattr(self, "__origin__", "")).encode("utf-8")
cdef bytes encoded_name
try:
encoded_name = (name or getattr(self, "__origin__", "")).encode("utf-8")
except SystemError as e:
if str(e) == "bad argument to internal function":
# This can happen if Semaphore is subclassed in a mypyc extension module due to conflict with getattr. No problem.
encoded_name = b""
else:
raise

cdef Py_ssize_t length = len(encoded_name)

# Allocate memory for the char* and add 1 for the null character
Expand Down
Loading