Skip to content

fix(test) test init subclass with recent __class_getitem__ changes #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BobTheBuidler wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(test) test init subclass with recent __class_getitem__ changes #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25130d5
fix(test) test init subclass with recent `__class_getitem__` changes
BobTheBuidler Apr 28, 2025
535b388
fix-params
BobTheBuidler Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pytest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,5 @@ jobs:
pip install -e .

- name: Run test suite
run: pytest
run: pytest -v

18 changes: 15 additions & 3 deletions a_sync/iter.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,11 @@ class ASyncIterable(_ASyncIterable):
else:
args = (arg_or_args,)
return _class_getitem(cls, args)
return super().__class_getitem__(arg_or_args, **kwargs)

if hasattr(cls, "__parameters__"):
return super().__class_getitem__(arg_or_args, **kwargs)
else:
return cls


cdef class _ASyncIterator(_AwaitableAsyncIterableMixin):
Expand Down Expand Up @@ -429,7 +433,11 @@ class ASyncIterator(_ASyncIterator):
else:
args = (arg_or_args,)
return _class_getitem(cls, args)
return super().__class_getitem__(arg_or_args, **kwargs)

if hasattr(cls, "__parameters__"):
return super().__class_getitem__(arg_or_args, **kwargs)
else:
return cls


class ASyncGeneratorFunction(Generic[P, T]):
Expand Down Expand Up @@ -795,7 +803,11 @@ class ASyncSorter(_ASyncSorter):
else:
args = (arg_or_args,)
return _class_getitem(cls, args)
return super().__class_getitem__(arg_or_args, **kwargs)

if hasattr(cls, "__parameters__"):
return super().__class_getitem__(arg_or_args, **kwargs)
else:
return cls


@lru_cache(maxsize=None)
Expand Down
Loading