Exclude RDS objects and rdsadmin DB from sp_Blitz checks #3713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrentOzar
requested changes
Oct 18, 2025
| IF @Debug IN (1, 2) RAISERROR('Running CheckId [%d].', 0, 1, 99) WITH NOWAIT; | ||
|
|
||
| EXEC dbo.sp_MSforeachdb 'USE [?]; SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED; IF EXISTS (SELECT * FROM sys.tables WITH (NOLOCK) WHERE name = ''sysmergepublications'' ) IF EXISTS ( SELECT * FROM sysmergepublications WITH (NOLOCK) WHERE retention = 0) INSERT INTO #BlitzResults (CheckID, DatabaseName, Priority, FindingsGroup, Finding, URL, Details) SELECT DISTINCT 99, DB_NAME(), 110, ''Performance'', ''Infinite merge replication metadata retention period'', ''https://www.brentozar.com/go/merge'', (''The ['' + DB_NAME() + ''] database has merge replication metadata retention period set to infinite - this can be the case of significant performance issues.'')'; | ||
| EXEC dbo.sp_MSforeachdb 'USE [?]; |
There was a problem hiding this comment.
Why did we change this section?
There was a problem hiding this comment.
@BrentOzar I just added a new line for clarity.
| GROUP BY LEFT(physical_name, 1) | ||
| HAVING COUNT(*) > 1 | ||
| AND SUM(size) < 268435456 OPTION (RECOMPILE);'; | ||
| HAVING COUNT(*) > 1 AND SUM(size) < 268435456 |
There was a problem hiding this comment.
Why did we change this section?
There was a problem hiding this comment.
@BrentOzar I just reformatted the lines to separate the GROUP BY from the OPTION part for clarity.
|
I haven't heard back in a couple of weeks, so I'm going to go ahead and close this for now. If you'd like to resubmit it with only the relevant changes, though, we'd welcome it! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3712