Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/api/src/hook/hook.factory.spec.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ConfigService } from '@nestjs/config';
import { DataCordProcessor } from './processors/datacord.processor';
import { EmailProcessor } from './processors/email.processor';
import { HookProcessorFactory } from './hook.factory';
import { HookFactory } from './hook.factory';
import { HookType } from '../models';
import { HttpService } from '@nestjs/axios';
import { ModuleRef } from '@nestjs/core';
Expand All @@ -13,7 +13,7 @@ import { faker } from '@faker-js/faker';

describe('HookProcessorFactory', () => {
let moduleRef: ModuleRef;
let factory: HookProcessorFactory;
let factory: HookFactory;
let emailProcessor: EmailProcessor;
let dataCordProcessor: DataCordProcessor;
let webhookProcessor: WebhookProcessor;
Expand Down Expand Up @@ -48,7 +48,7 @@ describe('HookProcessorFactory', () => {
useValue: {},
},
{
provide: HookProcessorFactory,
provide: HookFactory,
useValue: {
getProcessor: jest.fn(),
},
Expand Down Expand Up @@ -84,7 +84,7 @@ describe('HookProcessorFactory', () => {
emailProcessor = module.get<EmailProcessor>(EmailProcessor);
webhookProcessor = module.get<WebhookProcessor>(WebhookProcessor);
dataCordProcessor = module.get<DataCordProcessor>(DataCordProcessor);
factory = new HookProcessorFactory(moduleRef);
factory = new HookFactory(moduleRef);
});

it('should return an instance of EmailProcessor for HookType.email', () => {
Expand Down
22 changes: 21 additions & 1 deletion apps/api/src/hook/hook.factory.ts
Original file line number Diff line number Diff line change
@@ -1,22 +1,34 @@
import { Injectable, Type } from '@nestjs/common';

import { DataCordProcessor } from './processors/datacord.processor';
import { DataCordTemplating } from './templater/datacord.hook.templating';
import { EmailProcessor } from './processors/email.processor';
import { HookInterface } from './models/hook.interface';
import { HookTemplatingInterface } from './templater/hook.templating';
import { HookType } from '../models';
import { ModuleRef } from '@nestjs/core';
import { WebhookProcessor } from './processors/webhook.processor';
import { WebhookTemplating } from './templater/webhook.hook.templating';

@Injectable()
export class HookProcessorFactory {
export class HookFactory {
private readonly processorMap: { [key in HookType]: Type<HookInterface> };
private readonly hookTemplatingMap: {
[key in HookType]: Type<HookTemplatingInterface>;
};

constructor(private moduleRef: ModuleRef) {
this.processorMap = {
[HookType.email]: EmailProcessor,
[HookType.webhook]: WebhookProcessor,
[HookType.datacord]: DataCordProcessor,
};

this.hookTemplatingMap = {
[HookType.email]: WebhookTemplating,
[HookType.webhook]: WebhookTemplating,
[HookType.datacord]: DataCordTemplating,
};
}

getProcessor(hookType: HookType): HookInterface {
Expand All @@ -26,4 +38,12 @@ export class HookProcessorFactory {
}
return this.moduleRef.get(processorClass, { strict: false });
}

getTemplating(hookType: HookType): HookTemplatingInterface {
const templatingClass = this.hookTemplatingMap[hookType];
if (!templatingClass) {
throw new Error(`Unsupported hook type: ${hookType}`);
}
return this.moduleRef.get(templatingClass, { strict: false });
}
}
12 changes: 9 additions & 3 deletions apps/api/src/hook/hook.module.ts
Original file line number Diff line number Diff line change
@@ -1,19 +1,25 @@
import { ConfigModule } from '@nestjs/config';
import { DataCordProcessor } from './processors/datacord.processor';
import { DataCordTemplating } from './templater/datacord.hook.templating';
import { EmailModule } from '../email/email.module';
import { EmailProcessor } from './processors/email.processor';
import { HookProcessorFactory } from './hook.factory';
import { EmailTemplating } from './templater/email.hook.templating';
import { HookFactory } from './hook.factory';
import { Module } from '@nestjs/common';
import { WebhookProcessor } from './processors/webhook.processor';
import { WebhookTemplating } from './templater/webhook.hook.templating';

@Module({
imports: [EmailModule, ConfigModule],
providers: [
EmailProcessor,
WebhookProcessor,
DataCordProcessor,
HookProcessorFactory,
WebhookTemplating,
DataCordTemplating,
EmailTemplating,
HookFactory,
],
exports: [HookProcessorFactory],
exports: [HookFactory],
})
export class HookModule {}
12 changes: 9 additions & 3 deletions apps/api/src/hook/processors/webhook.processor.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ describe('WebHookProcessor', () => {
const mockResponse = {
data: faker.string.alpha(),
status: 200,
headers: ['content-type: application/json'],
headers: {
'content-type': 'application/json',
},
};
mockAxios.mockResolvedValueOnce(mockResponse);
const webHookRequest = MockFactory(WebHookRequestFixture).one();
Expand Down Expand Up @@ -93,7 +95,9 @@ describe('WebHookProcessor', () => {
},
},
status: 200,
headers: ['content-type: application/json'],
headers: {
'content-type': 'application/json',
},
};
mockAxios.mockResolvedValueOnce(mockResponse);

Expand Down Expand Up @@ -126,7 +130,9 @@ describe('WebHookProcessor', () => {
const webHookRequest = {
url: 'http://example.com/api/data',
method: WebhookHttpMethod.GET,
headers: ['Accept: application/json'],
headers: {
'content-type': 'application/json',
},
values: {},
success_path:
Constants.prefixPattern + 'someProperty.anotherProperty.targetProperty',
Expand Down
16 changes: 1 addition & 15 deletions apps/api/src/hook/processors/webhook.processor.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,7 @@ export class WebhookProcessor implements HookInterface {

async sendWebhookAsync(params: WebhookParams): Promise<WebHookResponse> {
try {
const {
url,
headers: headerStrings,
method,
values,
success_path,
} = params;
const headers = {};

for (const header of headerStrings) {
const index = header.indexOf(':');
const key = header.substring(0, index).trim();
const value = header.substring(index + 1).trim();
headers[key] = value;
}
const { url, headers, method, values, success_path } = params;

const requestData = {};
for (const key in values) {
Expand Down
15 changes: 15 additions & 0 deletions apps/api/src/hook/templater/datacord.hook.templating.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { DataCordParams } from '../models';
import { HookTemplating } from './hook.templating';

export class DataCordTemplating extends HookTemplating {
//override applyToTemplate in abstract base class
applyTemplate(
params: DataCordParams,
templateKeyPairs: { [key: string]: string },
): void {
params.values = this.transformTemplateValues(
params.values,
templateKeyPairs,
);
}
}
11 changes: 11 additions & 0 deletions apps/api/src/hook/templater/email.hook.templating.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { HookTemplating } from './hook.templating';
import { WebhookParams } from '../../models';

export class EmailTemplating extends HookTemplating {
applyTemplate(
params: WebhookParams,
templateKeyPairs: { [key: string]: string },
): void {
console.log('EmailTemplating', params, templateKeyPairs);
}
}
52 changes: 52 additions & 0 deletions apps/api/src/hook/templater/hook.templating.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
import { Constants, HookParams } from '../../models';

export interface HookTemplatingInterface {
applyTemplate(
params: HookParams,
templateKeyPairs: { [key: string]: string },
): void;
}

export abstract class HookTemplating implements HookTemplatingInterface {
abstract applyTemplate(
params: any,
templateKeyPairs: { [key: string]: string },
): void;

transformTemplateValues = (
values: { [key: string]: string },
output: { [key: string]: string },
): { [key: string]: string } => {
const transformedValues: { [key: string]: string } = {};
const valuesCopy = JSON.parse(JSON.stringify(values)) as {
[key: string]: string;
};
const regexPattern = `\\{(?:\\${Constants.prefixPattern})?fields\\.([^}]+)\\}`;
const fieldPlaceholderPattern = new RegExp(regexPattern);
const globalFieldPlaceholderPattern = new RegExp(regexPattern, 'g');

Object.entries(valuesCopy).forEach(([key, value]) => {
const originalValue = value;
const matches = originalValue.match(globalFieldPlaceholderPattern);

if (matches) {
let transformedValue = originalValue;
matches.forEach((match) => {
const fieldPattern = fieldPlaceholderPattern;
const field = match
.replace(fieldPattern, '$1')
.replace('.value', '')
.replace(Constants.encryptSuffix, '');
transformedValue = transformedValue.replace(
match,
output[field] || output[field + Constants.encryptSuffix] || '',
);
});
transformedValues[key] = transformedValue;
} else {
transformedValues[key] = value;
}
});
return transformedValues;
};
}
18 changes: 18 additions & 0 deletions apps/api/src/hook/templater/webhook.hook.templating.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { HookTemplating } from './hook.templating';
import { WebhookParams } from '../../models';

export class WebhookTemplating extends HookTemplating {
applyTemplate(
params: WebhookParams,
templateKeyPairs: { [key: string]: string },
): void {
params.values = this.transformTemplateValues(
params.values,
templateKeyPairs,
);
params.headers = this.transformTemplateValues(
params.headers,
templateKeyPairs,
);
}
}
4 changes: 2 additions & 2 deletions apps/api/src/manifest/manifest.controller.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import Ajv from 'ajv';
import { BullModule } from '@nestjs/bull';
import { ConfigService } from '@nestjs/config';
import { EmailProcessor } from '../hook/processors/email.processor';
import { HookProcessorFactory } from '../hook/hook.factory';
import { HookFactory } from '../hook/hook.factory';
import { HttpService } from '@nestjs/axios';
import { HttpStatus } from '@nestjs/common';
import { ManifestController } from './manifest.controller';
Expand Down Expand Up @@ -94,7 +94,7 @@ describe('ManifestController', () => {
ManifestService,
{ provide: 'Ajv', useValue: new Ajv({ allErrors: true }) },
{
provide: HookProcessorFactory,
provide: HookFactory,
useValue: {
getProcessor: jest.fn(),
},
Expand Down
8 changes: 4 additions & 4 deletions apps/api/src/manifest/manifest.service.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { decrypt, generateHmac, verifyHmac } from '../utils/crypto-helpers';
import Ajv from 'ajv';
import { AxiosResponse } from 'axios';
import { EmailProcessor } from '../hook/processors/email.processor';
import { HookProcessorFactory } from './../hook/hook.factory';
import { HookFactory } from './../hook/hook.factory';
import { HttpService } from '@nestjs/axios';
import { ManifestService } from './manifest.service';
import { MockFactory } from 'mockingbird';
Expand All @@ -36,7 +36,7 @@ describe('ManifestService', () => {
'd01858dd2f86ab1d3a7c4a152e6b3755a9eff744999b3a07c17fb9cbb363154e';
let manifestService: ManifestService;
let httpService: HttpService;
let hookProcessorFactory: HookProcessorFactory;
let hookProcessorFactory: HookFactory;
let webHookProcessor: WebhookProcessor;
const queueMock = { add: jest.fn() };

Expand All @@ -56,7 +56,7 @@ describe('ManifestService', () => {
},
},
{
provide: HookProcessorFactory,
provide: HookFactory,
useValue: {
getProcessor: jest.fn(),
},
Expand All @@ -83,7 +83,7 @@ describe('ManifestService', () => {
manifestService = module.get<ManifestService>(ManifestService);
httpService = module.get<HttpService>(HttpService);
hookProcessorFactory =
module.get<HookProcessorFactory>(HookProcessorFactory);
module.get<HookFactory>(HookFactory);
webHookProcessor = module.get<WebhookProcessor>(WebhookProcessor);
});

Expand Down
Loading