Have dominion autoload use both names and codes (alt) #908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artoonie
force-pushed
the
feature/issue-866_fix-dominion-autoload-alt
branch
from
afa12ec to
80e4677
Compare
artoonie
force-pushed
the
feature/issue-866_fix-dominion-autoload-alt
branch
from
80e4677 to
a8b94fd
Compare
Collaborator
|
I'm using the I get every single candidate in the CVRs using this code. Can we use the configured contest id to filter to just the contest we're interested in? Auto-Loaded with this code Old configured list for the test data |
yezr
reviewed
Dec 4, 2024
Collaborator
|
Added to 3.0 dreams our discussion about reviewing the |
yezr
approved these changes
Jan 16, 2025
Collaborator
yezr
left a comment
yezr
left a comment
There was a problem hiding this comment.
Approved following 11/14 code review!
This was referenced Jan 16, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate approach to #901
Closes #866
Rather than reading the full CVR then cross-checking the CandidateManifest, only use the candidate manifest.
This speeds up autoloading, but has the downside of including
(undeclared)as a candidate.This splits autoloading and undeclared candidate searching into two different steps. Theoretically this should not be a problem: there should be no candidate found in the CVRs that are not found in the candidate manifest.
Let's discuss which approach feels better. I think this is a little cleaner than the other PR.