Skip to content

Make use of stb_image optional#323

Open
tksuoran wants to merge 1 commit intoBrunoLevy:mainfrom
tksuoran:make_stb_image_optional
Open

Make use of stb_image optional#323
tksuoran wants to merge 1 commit intoBrunoLevy:mainfrom
tksuoran:make_stb_image_optional

Conversation

@tksuoran
Copy link
Contributor

I only use geogram purely for geometry related features and as such I prefer to have minimal build of with without any non-essential features. This is also useful to avoid linking issues with STB image which I already link myself.

@BrunoLevy
Copy link
Owner

Hello,
I'd rather avoid adding too many options to the CMakeFiles that tend to become more and more complicated over the years and difficult to maintain. Is the presence of stb_image really blocking (besides being "non-aesthetic" if you use it somewhere else)? (normally no symbol is exported from stb_image since we define STB_IMAGE_STATIC and STB_IMAGE_WRITE_STATIC before importing it, do you still have duplicated symbols when you use stb_image in another place ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants