Skip to content

Conversation

@nmerget
Copy link
Contributor

@nmerget nmerget commented Jan 19, 2026

Description

Please provide the following information:

  • What changes you made:

fixed nested slots inside Mitosis components

  • Why you made them, and:

The slot was generated as attribute binding, but this might only the case in JSX based languages. Angular, Stencil and Vue using the default HTML slot syntax, which requires to add it as children with the slot attribute.

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

  • format the codebase: from the root, run yarn fmt:prettier.
  • update all snapshots (in core & CLI): from the root, run yarn test:update
  • add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

@nmerget nmerget requested a review from samijaber as a code owner January 19, 2026 20:37
@changeset-bot
Copy link

changeset-bot bot commented Jan 19, 2026

🦋 Changeset detected

Latest commit: f1bc362

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Patch
@builder.io/mitosis-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Jan 19, 2026

View your CI Pipeline Execution ↗ for commit f1bc362

Command Status Duration Result
nx run-many --target test ✅ Succeeded 5m 7s View ↗
nx e2e @builder.io/e2e-app ✅ Succeeded 1m 22s View ↗
nx run-many --target build --exclude @builder.i... ✅ Succeeded 2m 31s View ↗
nx build @builder.io/mitosis-site ✅ Succeeded 2m 18s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-19 20:46:30 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant