Skip to content

fix: changed ResultCode and ResponseCode to have int | str type due t…#27

Merged
RafaelJohn9 merged 1 commit intodevfrom
fix/ReturnCode
Aug 19, 2025
Merged

fix: changed ResultCode and ResponseCode to have int | str type due t…#27
RafaelJohn9 merged 1 commit intodevfrom
fix/ReturnCode

Conversation

@RafaelJohn9
Copy link
Copy Markdown
Member

Description

  • In Mpesa Daraja API there is always a mismatch in the Result and Response Code being either str or int. I've refactored for the response schemas to support this.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires documentation update
  • Refactor (code structure improvements, no new functionality)
  • Tests (addition or improvement of tests)
  • Chore (changes to tooling, CI/CD, or metadata)

How Has This Been Tested?

Checklist

  • My code follows the project's coding style guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings or errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Additional Context

…o the different return type by the Safaricom API

Signed-off-by: rafaeljohn9 <rafaeljohb@gmail.com>
@RafaelJohn9 RafaelJohn9 merged commit 4c192f8 into dev Aug 19, 2025
7 checks passed
@RafaelJohn9 RafaelJohn9 deleted the fix/ReturnCode branch August 19, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant