Open
Conversation
macqueen0987
reviewed
Apr 1, 2025
macqueen0987
left a comment
There was a problem hiding this comment.
깔끔하게 잘 하신 것 같습니다!
자동차 이름의 유효성 검사가 자동가 클래스 내부에 있는부분이 좋았습니다. 제가 미처 생각하지 못했던 부분입니다.
Member
|
자동차 입력을 쉼표로 split하는데 어떤 경우에 자동차 이름에 쉼표가 들어가는지 궁금합니다 |
glucosei
reviewed
Apr 1, 2025
glucosei
left a comment
There was a problem hiding this comment.
예외처리와 Car클래스가 굉장히 깔끔하게 된 것 같습니다. Application 클래스의 책임을 나눌 수 있으면 좋을 것 같습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Car.java
Application.java
TryCount)를 검증하여 양의 정수만 허용합니다.