Open
Conversation
macqueen0987
left a comment
macqueen0987
left a comment
There was a problem hiding this comment.
생각보다 테이블 수가 많아서 놀랐지만 잘 만드신거 같습니다!
고형인/chapter5/src/main/java/cau/ict/btrack/domain/NotifySetting.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
이럴경우 enum 보다는 카럼명을 isInactive 와 같이 설정하는걸 저는 개인적으로 좋아합니다!
Member
Author
There was a problem hiding this comment.
isInactive로 하면 TRUE/FALSE로 비활성화 여부를 나타내는데 직관적이지 않은 느낌이라 저는 이렇게 하긴 했습니다
dp44rk
reviewed
May 20, 2025
There was a problem hiding this comment.
setter 대신 builder 어노테이션을 사용하면 어느 부분에서 더 좋은가요?
There was a problem hiding this comment.
dto가 아니라 엔티티기 때문에 한 번 생성할 때 값을 넣고 불변을 유지하는게 무결성 측면에서 유리하다고 알고 있습니다
Member
Author
There was a problem hiding this comment.
사실 워크북에 @builder로 되어 있어서 쓰긴 했는데 위에서 잘 설명해주셨네요
저도 방금 찾아보면서 알았습니담..
glucosei
reviewed
May 20, 2025
고형인/chapter5/src/main/java/cau/ict/btrack/domain/Announcement.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ERD