Open
Conversation
added 10 commits
May 19, 2025 10:19
hyungin0505
reviewed
May 20, 2025
Member
hyungin0505
left a comment
There was a problem hiding this comment.
hastag, nikname 같은 사소한 오타 제외하고는 모두 좋아 보입니다
Member
There was a problem hiding this comment.
반납 기한 칼럼과 함께 반납일 칼럼도 만드신 것이 좋은 것 같습니다.
Member
There was a problem hiding this comment.
비밀번호 같은 민감 정보는 평문이 아니라 암호화해서 저장하는 것이 좋을 것 같습니다
length=20은 해시를 저장하기에는 조금 짧아 보입니다
macqueen0987
left a comment
There was a problem hiding this comment.
깔끔했습니다! 비밀번호 관련 부분은 저도 지적하려 했는데 이미 지적 해주셨네요.
added 3 commits
May 20, 2025 17:16
glucosei
reviewed
May 20, 2025
There was a problem hiding this comment.
대여는 실제로 존재하는 책 한권 한권에 대해, 해쉬태그나 좋아요는 같은 책끼리 묶은 특정한 책이라는 것에 대해 연관이 있어서 다른 엔티티를 하나 더 만드는 것이 좋다고 생각합니다. 같은 책이 여러 권 있는 경우가 대다수이기 때문에!
There was a problem hiding this comment.
Alarm 클래스를 만들어서 MarketingAlarm extends Alarm 하면 좋을듯합니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User.java
Book.java
BookCategory.java
HasTag.java
NoticeAlarm.java
MarketingAlarm.java
BaseEntity.java
Gender.java
BookHasTag.java
Likes.java
Rental.java