AutoBuff: Better inventory open state checks + AutoSoup autostack#7894
Open
DaviSMoura wants to merge 2 commits intoCCBlueX:nextgenfrom
Open
AutoBuff: Better inventory open state checks + AutoSoup autostack#7894DaviSMoura wants to merge 2 commits intoCCBlueX:nextgenfrom
DaviSMoura wants to merge 2 commits intoCCBlueX:nextgenfrom
Conversation
DaviSMoura
changed the title
MukjepScarlet
requested review from
1zun4 and
MukjepScarlet
and removed request for
MukjepScarlet
1zun4
reviewed
Mar 25, 2026
Comment on lines
+87
to
+90
| when { | ||
| DropAfterUse.enabled -> handleDropAfterUse(slot) | ||
| SoupStacker.enabled -> handleSoupStacker(slot) | ||
| } |
Member
There was a problem hiding this comment.
Won't this mean this will only run SoupStacker if DropAfterUse is disabled. Feels a bit odd, shouldn't this be a mode then?
1zun4
reviewed
Mar 25, 2026
Comment on lines
+109
to
+121
| internal val ignoreInventoryOpen by boolean("IgnoreInventoryOpen", false) | ||
| internal val inventoryCheckMode by enumChoice("InventoryCheckMode", InventoryCheckMode.SERVER_SIDE) | ||
|
|
||
| enum class InventoryCheckMode(override val tag: String) : Tagged { | ||
| SERVER_SIDE("ServerSide"), | ||
| CLIENT_SIDE("ClientSide") | ||
| } | ||
|
|
||
| internal val isInventoryOpenForCheck: Boolean | ||
| get() = when (inventoryCheckMode) { | ||
| InventoryCheckMode.SERVER_SIDE -> InventoryManager.isInventoryOpenServerSide | ||
| InventoryCheckMode.CLIENT_SIDE -> isInInventoryScreen | ||
| } |
Member
There was a problem hiding this comment.
This is broken. Revert this change. The idea of isInventoryOpenServerSide is that a server only knows our inventory is open if we have clicked. This means the module won't do anything until we clicked a slot...
1zun4
requested changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better checks do open inventory when using AutoBuff:
And AutoSoup auto stack module :)