Skip to content

Conversation

steel-bucket
Copy link
Contributor

@steel-bucket steel-bucket commented Aug 23, 2025

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.
  • I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

  • I have never used CCExtractor.
  • I have used CCExtractor just a couple of times.
  • I absolutely love CCExtractor, but have not contributed previously.
  • I am an active contributor to CCExtractor.

Removes the share module and the sharing service.

@prateekmedia prateekmedia requested a review from Copilot August 24, 2025 15:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the share module and sharing service functionality from CCExtractor, completely eliminating the ability to share extracted captions via TCP and the CCTranslate integration features.

Key Changes:

  • Complete removal of protobuf-c dependency and related protocol buffer message structures
  • Elimination of sharing service functionality including TCP sharing and translation features
  • Code cleanup removing conditional compilation directives for sharing features

Reviewed Changes

Copilot reviewed 40 out of 44 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
windows/ccextractor.vcxproj.filters Removes protobuf-c and sharing-related source files from Windows build filters
windows/ccextractor.vcxproj Removes protobuf-c and sharing-related includes/sources from Windows project
src/thirdparty/protobuf-c/* Completely removes protobuf-c library files
src/rust/* Removes sharing-related feature flags and configuration from Rust components
src/lib_ccx/* Removes sharing service implementation and related protocol buffer files
src/ccextractor.* Removes sharing service initialization and cleanup calls
build files Updates various build configurations to remove protobuf-c dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@prateekmedia prateekmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prateekmedia prateekmedia changed the title [FEAT]Removed the share module [FEAT] Removed the share module Aug 24, 2025
@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit a34ba0f...:
Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 7/7
DVD 3/3
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 86/86
Teletext 21/21
WTV 13/13
XDS 34/34

Congratulations: Merging this PR would fix the following tests:


All tests passing on the master branch were passed completely.

Check the result page for more info.

@prateekmedia prateekmedia merged commit 4b5f68a into CCExtractor:master Aug 24, 2025
17 of 18 checks passed
@ccextractor-bot
Copy link
Collaborator

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit a34ba0f...:
Report Name Tests Passed
Broken 13/13
CEA-708 14/14
DVB 2/7
DVD 3/3
DVR-MS 2/2
General 27/27
Hauppage 3/3
MP4 3/3
NoCC 10/10
Options 85/86
Teletext 7/21
WTV 10/13
XDS 34/34

Your PR breaks these cases:

NOTE: The following tests have been failing on the master branch as well as the PR:

  • ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed:

    Never

  • ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed:

    Never

  • ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2..., Last passed:

    Never

  • ccextractor --out=srt --latin1 f23a544ba8..., Last passed:

    Never

  • ccextractor --out=srt --latin1 10f0f77cf4..., Last passed:

    Test 5993

  • ccextractor --out=srt --latin1 df3b4d62d3..., Last passed:

    Never


It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

hrideshmg pushed a commit to hrideshmg/ccextractor that referenced this pull request Aug 25, 2025
* replaced nanomsg with nanomsg_sys

* feat: Share Module - squash commits

* Share Module: Added Documentation

* Share Module: Removed Sharing Service

* Share: formatting issues

* Share: failing CI

* Share: failing CI

* Share: Removed protobuf

* Share Module: Update CHANGES.txt

* Share Module: Update Cargo.lock

* Share Module: Update CHANGES.txt

* Share Module: Update Cargo.toml

* Share Module: Update Cargo.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants