-
Notifications
You must be signed in to change notification settings - Fork 475
[FEAT] Removed the share module #1737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Removed the share module #1737
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the share module and sharing service functionality from CCExtractor, completely eliminating the ability to share extracted captions via TCP and the CCTranslate integration features.
Key Changes:
- Complete removal of protobuf-c dependency and related protocol buffer message structures
- Elimination of sharing service functionality including TCP sharing and translation features
- Code cleanup removing conditional compilation directives for sharing features
Reviewed Changes
Copilot reviewed 40 out of 44 changed files in this pull request and generated 6 comments.
Show a summary per file
File | Description |
---|---|
windows/ccextractor.vcxproj.filters | Removes protobuf-c and sharing-related source files from Windows build filters |
windows/ccextractor.vcxproj | Removes protobuf-c and sharing-related includes/sources from Windows project |
src/thirdparty/protobuf-c/* | Completely removes protobuf-c library files |
src/rust/* | Removes sharing-related feature flags and configuration from Rust components |
src/lib_ccx/* | Removes sharing service implementation and related protocol buffer files |
src/ccextractor.* | Removes sharing service initialization and cleanup calls |
build files | Updates various build configurations to remove protobuf-c dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Share Module: Update CHANGES.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit a34ba0f...:
Congratulations: Merging this PR would fix the following tests:
All tests passing on the master branch were passed completely. Check the result page for more info. |
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit a34ba0f...:
Your PR breaks these cases:
NOTE: The following tests have been failing on the master branch as well as the PR:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
* replaced nanomsg with nanomsg_sys * feat: Share Module - squash commits * Share Module: Added Documentation * Share Module: Removed Sharing Service * Share: formatting issues * Share: failing CI * Share: failing CI * Share: Removed protobuf * Share Module: Update CHANGES.txt * Share Module: Update Cargo.lock * Share Module: Update CHANGES.txt * Share Module: Update Cargo.toml * Share Module: Update Cargo.toml
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Removes the share module and the sharing service.