Adopt Principal Axes for Translational and Rotational Coordinates at All Levels #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f the moment of inertia rather than the diagonal elements for weighting
harryswift01
changed the title
…eighted_torques`
harryswift01
approved these changes
Jan 15, 2026
Contributor
harryswift01
left a comment
harryswift01
left a comment
There was a problem hiding this comment.
Thanks for making these changes @skfegan, they significantly reduce the complexity of the current axes calculations and make better use of existing MDAnalysis functionality. This should also lower the risk of bugs by relying on well-tested standard library routines. I’ve made a few minor, non-functional edits to the get_weighted_forces and get_weighted_torques functions, mainly consolidating inline comments into the docstrings to improve readability. Other than that, everything looks good to me, and I’m happy to approve this for merging.
jimboid
approved these changes
Jan 15, 2026
Member
jimboid
left a comment
jimboid
left a comment
There was a problem hiding this comment.
Harry has done a thorough review. All looks great.
This was referenced Jan 15, 2026
Closed
Closed
harryswift01
added a commit
that referenced
this pull request
Jan 16, 2026
harryswift01
added a commit
that referenced
this pull request
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Switching to using principal axes for translation and rotation at all levels.
Changes
Impact