Skip to content

Conversation

@briri
Copy link
Collaborator

@briri briri commented Nov 19, 2025

Fixes #758

Changes proposed in this PR:

  • Add rubyzip gem.
  • Update app/services/external_api/base_service.rb following the rubyzip docs to extract the files properly
  • Added some additional error handling to the unzip function
  • Updated all gem dependencies
  • Updated all JS dependencies

@briri briri requested a review from jupiter007 November 19, 2025 16:30
Copy link
Collaborator

@jupiter007 jupiter007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@briri briri merged commit ac493a3 into v5 Nov 21, 2025
0 of 8 checks passed
@briri briri deleted the bug/ror-download branch November 21, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants