Skip to content

Fix error in LSMR algorithm #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AnderBiguri merged 3 commits into from
Jan 6, 2026
Merged

Fix error in LSMR algorithm #698

AnderBiguri merged 3 commits into from
Jan 6, 2026

Conversation

@rozenn1
Copy link
Contributor

@rozenn1 rozenn1 commented Jan 6, 2026

  • fixes small error in python LSMR algorithm that used variable iter instead of i
  • fixes some typos, also including some incorrect optional variable names in the python demos/docstrings

rozenn1 added 3 commits January 6, 2026 09:50
@rozenn1
Fix error in LSMR algorithm
28143e9 
previously returned `UnboundLocalError: local variable 'iter' referenced before assignment`
@rozenn1
correct typos
2401bfa 
includes some incorrect optional variable names in docstring and demos of the python version
@rozenn1
Merge branch 'master' of https://github.com/CERN/TIGRE
82d12d6
@AnderBiguri
Copy link
Member

AnderBiguri commented Jan 6, 2026

Thanks!

@AnderBiguri AnderBiguri merged commit ce640c8 into CERN:master Jan 6, 2026
2 checks passed
@rozenn1 rozenn1 deleted the lsmr-branch branch January 6, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rozenn1 @AnderBiguri