Skip to content

2d handling for TV proximal algs #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AnderBiguri merged 2 commits into from
Jan 7, 2026
Merged

2d handling for TV proximal algs #700

AnderBiguri merged 2 commits into from
Jan 7, 2026

Conversation

@rozenn1
Copy link
Contributor

@rozenn1 rozenn1 commented Jan 7, 2026

  • I added a check to only run the function getting buffer slices into memory for 3d data in tv_proximal.cu, which allows FISTA, SART_TV, OS_SART_TV to be used for 2d reconstructions
  • correct docstring descriptions of the proj input to have shape = (nangles, geo.nDetector)

rozenn1 added 2 commits January 7, 2026 13:54
@rozenn1
fix typos
b282e0b 
including incorrect `proj` array shapes described in docstrings
@rozenn1
fix CERN#699
28881a9 
allow 2d reconstruction for algorithms using `tv_proximal` (FISTA, SART_TV, OS_SART_TV)
@AnderBiguri
Copy link
Member

AnderBiguri commented Jan 7, 2026

Thanks for this !

@AnderBiguri AnderBiguri merged commit 7cef2b3 into CERN:master Jan 7, 2026
2 checks passed
@rozenn1 rozenn1 deleted the tv_proximal_2d branch January 7, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rozenn1 @AnderBiguri