Misc changes #702
Open
Misc changes #702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise this branch is essentially a noop.
Looks like these can just be merged together?
Judging from the other patterns, it *looks* like we should be calling this. Also check_and_repmat seems to look for "COR" in its implementation, which increases my confidence. But maybe I'm wrong!
AnderBiguri
reviewed
Jan 15, 2026
| c_geom.offOrigX[i] = p_geometry.offOrigin[i][2] | ||
| c_geom.offOrigY[i] = p_geometry.offOrigin[i][1] | ||
| c_geom.offOrigZ[i] = p_geometry.offOrigin[i][0] | ||
| for i in range(total_projections): |
Member
There was a problem hiding this comment.
I think this should be the oposite, i.e. we need to ensuire DSO comes as a vector rather than a scalar from check_geo(). Many users have varying DSO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was reading the codebase and found some small changes we may or may not want to make. Context is included in the commit subjects and bodies :)