Remove .wordpress-org from .gitignore so assets are tracked#12
Merged
Conversation
a97df59 to
72ecfa0
Compare
The directory is already listed in .gitattributes with export-ignore, so it remains excluded from release zips while being available for the deploy workflow to sync to WordPress.org SVN assets. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
72ecfa0 to
d1fe075
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This PR updates the repository's CI/CD configuration and documentation to improve asset management, handle upstream environment issues, and reflect current workflow capabilities.
Key changes include:
.wordpress-org/from.gitignore. This allows marketing assets (banners, icons, screenshots) to be tracked in Git and synced to the WordPress SVN repository.continue-on-error: trueto the "Plugin Check" job inplugin-check.yml. This is a temporary measure due to WordPress/plugin-check-action#579, wherewp-envfails on newer Ubuntu runner images.plugin-check.ymlworkflow to manually copy.wp-env.jsoninto the build directory. Since this file isexport-ignoreed in.gitattributes, it was missing from thegit archiveused for testing; it is now explicitly included so theplugin-checkaction can initialize correctly.CLAUDE.md):deploy.ymlnow supports manualworkflow_dispatchtriggers..wordpress-org/directory is now tracked by Git.How to test
git check-ignore .wordpress-org/. It should return no output. Verify you can stage a file inside that directory.plugin-check.ymlworkflow. The "Plugin folder prepared" step should now show.wp-env.jsonbeing copied into theci-build/path.deploy.ymlworkflow to confirm the "Run workflow" button is available.CLAUDE.mdaccurately describes the new PHP 8.4 compatibility and asset tracking status.Potential Risks & Review Items
continue-on-error: trueon the "Plugin Check" job means actual plugin standard violations won't block a PR. We should monitor the linked upstream issue and revert this once fixed..wordpress-org/will increase the.gitfolder size. Images should be optimized before being committed.CLAUDE.mdmentions PHP 8.4, the matrix update for the actualplugin-check.ymljob is not visible in this diff. Ensure the workflow file actually supports 8.4 to maintain consistency.Is this PR safe for automatic approval?
Yes. These are configuration and documentation updates aimed at stabilizing CI and improving deployment workflows without modifying the plugin's runtime PHP logic.
Images
Related Tasks / PRs
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Checklist