Skip to content

Remove .wordpress-org from .gitignore so assets are tracked#12

Merged
wzul merged 1 commit into
mainfrom
fix/wordpress-org-gitignore
May 29, 2026
Merged

Remove .wordpress-org from .gitignore so assets are tracked#12
wzul merged 1 commit into
mainfrom
fix/wordpress-org-gitignore

Conversation

@wzul

@wzul wzul commented May 29, 2026

Copy link
Copy Markdown
Collaborator

What does this change?

This PR updates the repository's CI/CD configuration and documentation to improve asset management, handle upstream environment issues, and reflect current workflow capabilities.

Key changes include:

  • Asset Tracking: Removed .wordpress-org/ from .gitignore. This allows marketing assets (banners, icons, screenshots) to be tracked in Git and synced to the WordPress SVN repository.
  • CI Reliability Workaround: Added continue-on-error: true to the "Plugin Check" job in plugin-check.yml. This is a temporary measure due to WordPress/plugin-check-action#579, where wp-env fails on newer Ubuntu runner images.
  • Build Process Improvement: Updated the plugin-check.yml workflow to manually copy .wp-env.json into the build directory. Since this file is export-ignoreed in .gitattributes, it was missing from the git archive used for testing; it is now explicitly included so the plugin-check action can initialize correctly.
  • Documentation Updates (CLAUDE.md):
    • Added PHP 8.4 to the documented compatibility matrix.
    • Documented that deploy.yml now supports manual workflow_dispatch triggers.
    • Updated file conventions to reflect that the .wordpress-org/ directory is now tracked by Git.

How to test

  1. Verify Asset Tracking: Run git check-ignore .wordpress-org/. It should return no output. Verify you can stage a file inside that directory.
  2. Verify CI Build Logic: Review the logs of the plugin-check.yml workflow. The "Plugin folder prepared" step should now show .wp-env.json being copied into the ci-build/ path.
  3. Verify Workflow Dispatch: Check the GitHub Actions tab for the deploy.yml workflow to confirm the "Run workflow" button is available.
  4. Documentation Review: Ensure CLAUDE.md accurately describes the new PHP 8.4 compatibility and asset tracking status.

Potential Risks & Review Items

  • CI Blindness: Setting continue-on-error: true on the "Plugin Check" job means actual plugin standard violations won't block a PR. We should monitor the linked upstream issue and revert this once fixed.
  • Repository Size: Tracking binary assets (images) in .wordpress-org/ will increase the .git folder size. Images should be optimized before being committed.
  • Documentation Drift: While CLAUDE.md mentions PHP 8.4, the matrix update for the actual plugin-check.yml job is not visible in this diff. Ensure the workflow file actually supports 8.4 to maintain consistency.

Is this PR safe for automatic approval?

Yes. These are configuration and documentation updates aimed at stabilizing CI and improving deployment workflows without modifying the plugin's runtime PHP logic.

Images

Related Tasks / PRs

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com

Checklist

  • Unit tests provided?
  • All tests passing?
  • Tested in staging?
  • Task link provided?

@wzul wzul force-pushed the fix/wordpress-org-gitignore branch 4 times, most recently from a97df59 to 72ecfa0 Compare May 29, 2026 08:27
The directory is already listed in .gitattributes with export-ignore, so it remains excluded from release zips while being available for the deploy workflow to sync to WordPress.org SVN assets.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@wzul wzul force-pushed the fix/wordpress-org-gitignore branch from 72ecfa0 to d1fe075 Compare May 29, 2026 08:35
@wzul wzul merged commit 5e9c7ef into main May 29, 2026
9 of 10 checks passed
@wzul wzul deleted the fix/wordpress-org-gitignore branch May 29, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant