This repository was archived by the owner on May 13, 2026. It is now read-only.
[codex] fix security advisory and toolcall parsing issues#476
Merged
Conversation
feat: enhance DSML tool-call parsing drift tolerance and update API docs
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 243860f6d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the two low-severity issues reported in GHSA-rf34-c5jc-4ffw and tightens adjacent tool-call parsing edge cases:
keyandapi_keyquery parameters before access logs are emitted, without mutating the live request.?key=secret;alt=sseand?api_key=secret%ZZ, so sensitive values do not leak whenurl.ParseQueryfails.Root Cause
The WebUI fallback used a raw prefix check against
staticDir, which did not require a path separator boundary. The access logger delegated to chi's default formatter with the fullRequestURI, including sensitive query parameters used by Gemini-compatible clients; the first redaction pass also returned unredacted output when query parsing failed before producing parsed pairs.For tool calls, inline Markdown examples were only partially ignored. Non-stream parsing originally stripped inline code spans too broadly, which could remove backticks from real parameter values, while stream detection did not carry inline-code state across chunks.
Validation
./scripts/lint.sh./tests/scripts/check-refactor-line-gate.sh./tests/scripts/run-unit-all.shnpm run build --prefix webui