PLT-1253: Remove legacy terraform backends

[christopher-maboh]

🎫 Ticket

https://jira.cms.gov/browse/PLT-1253

🛠 Changes

legacy terraform backends were removed

ℹ️ Context

With legacy accounts deleted, the is the need to remove terraform backends for this legacy accounts

🧪 Validation

See checks.

[gsf]

This PR should update backends to drop the -gf suffix and update workflows to point at non-gf backends.

[christopher-maboh]

This PR should update backends to drop the -gf suffix and update workflows to point at non-gf backends.

[christopher-maboh]

All checks now passing. got a .terraform/modules/iam_github_oidc_provider/modules/iam-github-oi…
…dc-provider does not exist earlier. checked documentation and seems source has to be source = "terraform-aws-modules/iam/aws//modules/iam-oidc-provider" and not source = "terraform-aws-modules/iam/aws//modules/iam-github-oidc-provider"

[gsf]

All checks now passing. got a .terraform/modules/iam_github_oidc_provider/modules/iam-github-oi… …dc-provider does not exist earlier. checked documentation and seems source has to be source = "terraform-aws-modules/iam/aws//modules/iam-oidc-provider" and not source = "terraform-aws-modules/iam/aws//modules/iam-github-oidc-provider"

Looks like that rename was merged a couple of days ago terraform-aws-modules/terraform-aws-iam#585

[gsf]

Looks like the api_customers IP set for AB2D is now handled in their app repo, so modify the api-waf service and remove it from that state.

[gsf]

I'm seeing other changes to the WAF rules in the api-waf plan on AB2D environments. Let's remove ab2d from the tf-api-waf workflow matrix and undo the changes made to the api-waf service.

[gsf]

The file at terraform/services/github-actions-oidc-provider/.terraform.lock.hcl should be removed from version control.

[christopher-maboh]

The file at terraform/services/github-actions-oidc-provider/.terraform.lock.hcl should be removed from version control.

.terraform.lock.hcl from version control has been dropped

[gsf]

Looks good! Thanks for working in changes