Skip to content

Conversation

@juliareynolds-nava
Copy link
Contributor

@juliareynolds-nava juliareynolds-nava commented Sep 23, 2025

🎫 Ticket

https://jira.cms.gov/browse/PLT-1227

🛠 Changes

Added a cost anomaly cost monitor and sns topic subscription. This is the first part of required work for this feature. A lambda to push alerts to slack will be completed in PLT-1361

ℹ️ Context

Users want to be alerted in Slack about significant cost fluctuations, so that we can take actions on addressing potential cost anomalies.

🧪 Validation

See check here: https://github.com/CMSgov/cdap/actions/runs/18880866713

@juliareynolds-nava juliareynolds-nava marked this pull request as ready for review September 24, 2025 20:40
@juliareynolds-nava juliareynolds-nava marked this pull request as ready for review September 30, 2025 16:50
@juliareynolds-nava juliareynolds-nava requested review from a team and gsf October 1, 2025 20:43
@juliareynolds-nava juliareynolds-nava requested a review from gsf October 3, 2025 13:36
@juliareynolds-nava juliareynolds-nava requested a review from a team October 23, 2025 18:10
app = "bcda"
env = var.env
function_name = local.function_name
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the count argument errors you're seeing in the workflow runs, I think we need to iterate on the queue module.

As we discussed, add source and override documents to our sqs module as in the open source sqs module (but with simpler naming):

  source_policy_documents   = var.source_policy_documents
  override_policy_documents = var.override_policy_documents

If we add those variables to our module with [] as defaults then there should be nothing backwards-incompatible. That can be done in this PR.

Then pass a source document into the queue module, and define the sns topic subscription at the end of this file instead of passing in the topic arn.

This may still result in a need to run with -exclude arguments for the initial apply. Please ping me if that's the case.

@juliareynolds-nava juliareynolds-nava requested review from a team and gsf October 28, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants