Skip to content

Conversation

@jamesrhester
Copy link
Contributor

G Madariaga has supplied extensive updates to the dictionary. Note that some definitions rely on additions to templ_attr.cif that have not yet been merged.

@jamesrhester
Copy link
Contributor Author

CI checks will not be successful until templ_attr.cif has been updated.

@vaitkus
Copy link
Collaborator

vaitkus commented Dec 13, 2024

I tried running some checks on this PR with the updated version of the templ_attr.cif file (see COMCIFS/cif_core#508). I suggested some changes to the template and a separate PR (see jamesrhester#1) to resolve most of the issues flagged by the formal validation. However, one issue still remains.

The _description_example.case in the _cell.commen_supercell_matrix save frame is given as a free-form text field while the validator expects it to be a vector, e.g. be a valid value that could be assigned to the _cell.commen_supercell_matrix item. I am unsure what is the best way to resolve this. Maybe the text part could be moved to the _description_example.detail data item of to the category level examples altogether.

Issues flagged by the cif_ddlm_dictionary_check script are a bit too numerous so it might be better to merge both the templ_attr.cif and the this PR and address them in subsequent cleanup PRs.

@jamesrhester
Copy link
Contributor Author

I am withdrawing this pull request in order to start again from the latest version and to incorporate later updates from @gmadaria

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants