Check if correct dbus library is found during cmake phase not #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can determine if correct DBus library (patched one) has been found during CMake phase and give a nice error to the user rather than having a compiler error. This patch only checks if dbus_connection_send_with_reply_set_notify function is present in dbus headers, but this can be easily extended to check for all patches that are needed.
goncaloalmeida
suggested changes
Nov 10, 2023
Contributor
goncaloalmeida
left a comment
goncaloalmeida
left a comment
There was a problem hiding this comment.
why the cpp code? tests?
cc @fcmonteiro @dibpinto @DiogoPedrozza
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can determine if correct DBus library (patched one) has been found
during CMake phase and give a nice error to the user rather than having
a compiler error.
This patch only checks if dbus_connection_send_with_reply_set_notify
function is present in dbus headers, but this can be easily extended to
check for all patches that are needed.