refactor: safe PHP 7.4 modernization

.omc/sessions/fa94e8de-1fa9-4329-8283-36f9ae53039c.json

@@ -0,0 +1,8 @@
+{
+  "session_id": "fa94e8de-1fa9-4329-8283-36f9ae53039c",
+  "ended_at": "2026-04-09T11:57:11.434Z",
+  "reason": "other",
+  "agents_spawned": 0,
+  "agents_completed": 0,
+  "modes_used": []
+}

.omc/sessions/ff0c1a6a-cc9f-4db8-b7c4-2fb53b2b07bb.json

@@ -0,0 +1,8 @@
+{
+  "session_id": "ff0c1a6a-cc9f-4db8-b7c4-2fb53b2b07bb",
+  "ended_at": "2026-04-09T12:08:17.277Z",
+  "reason": "other",
+  "agents_spawned": 0,
+  "agents_completed": 0,
+  "modes_used": []
+}

cache/index.php

@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types=1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

images/index.php

@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types=1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

include/global_arrays.php

@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types=1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

include/global_forms.php

@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types=1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |
@@ -23,22 +25,22 @@
 */
 
 $fields_template_edit = array(
-	'id' => array(
+	'id' => [
 		'method' => 'hidden_zero',
 		'value' => '|arg1:id|'
-	),
-	'data_template_id' => array(
+	],
+	'data_template_id' => [
 		'method' => 'hidden_zero',
 		'value' => '|arg1:data_template_id|'
-	),
-	'save_component_template' => array(
+	],
+	'save_component_template' => [
 		'method' => 'hidden_zero',
 		'value' => 1
-	),
-	'ds_enabled__0' => array(
+	],
+	'ds_enabled__0' => [
 		'method' => 'hidden_zero',
 		'value' => 'on'
-	),
+	],
 	'template_header' => array(
 		'friendly_name' => __('General', 'reportit'),
 		'method' => 'spacer',
@@ -126,10 +128,10 @@
 );
 
 $fields_template_export = array(
-	'action' => array(
+	'action' => [
 		'method' => 'hidden_zero',
 		'value' => 'template_export'
-	),
+	],
 	'template_id' => array(
 		'friendly_name' => __('Report Template', 'reportit'),
 		'description' => __('Choose one of your Report Templates to export to XML.', 'reportit'),

include/index.php

@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types=1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

index.php

@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types=1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

lib/const_graphs.php

@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types=1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |
@@ -28,12 +30,12 @@
 $affix           = '';
 $exponent        = '';
 $prefix          = '';
-$results         = array();
-$prefixes        = array();
-$x_values        = array();
-$report_ds_alias = array();
+$results         = [];
+$prefixes        = [];
+$x_values        = [];
+$report_ds_alias = [];
 
-$prefixes[1] = array(
+$prefixes[1] = [
 	0 => '',
 	1 => 'Ki',
 	2 => 'Mi',
@@ -43,9 +45,9 @@
 	6 => 'Ei',
 	7 => 'Zi',
 	8 => 'Yi'
-);
+];
 
-$prefixes[2] = array(
+$prefixes[2] = [
 	0 => '',
 	1 => 'k',
 	2 => 'M',
@@ -55,7 +57,7 @@
 	6 => 'E',
 	7 => 'Z',
 	8 => 'Y'
-);
+];
 
 $types = array(
 	'-10' => array (

lib/const_items.php

@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types=1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |
@@ -24,5 +26,5 @@
 
 //----- CONSTANTS FOR: items.php -----
 
-$link_array = array('name_cache', '');
+$link_array = ['name_cache', ''];
 

lib/const_measurands.php

@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types=1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |

lib/const_reports.php

@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types=1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |
@@ -128,7 +130,7 @@
 
 // $shifttime		- array, for dropdown menu
 //			- contains all possible timestamps of a day by using steps of 5 minutes
-$shifttime = array();
+$shifttime = [];
 
 for($i=0; $i<24; $i++) {
 	$hour=$i;
@@ -175,22 +177,22 @@
 		'id', 'name'
 	);
 } else {
-	$notify_lists = array();
+	$notify_lists = [];
 }
 
 $form_array_email = array(
 	'header_1' => array(
 		'friendly_name' => __('General', 'reportit'),
 		'method'        => 'spacer',
 	),
-	'id' => array(
+	'id' => [
 		'method' => 'hidden_zero',
 		'value'  => '|arg1:id|',
-	),
-	'tab' => array(
+	],
+	'tab' => [
 		'method' => 'hidden_zero',
 		'value'  => 'email',
-	),
+	],
 	'email_subject' => array(
 		'friendly_name' => __('Subject', 'reportit'),
 		'description'   => __('Enter the subject of your email.<br> Following variables will be supported (without quotes): \'|title|\' and \'|period|\'', 'reportit'),
@@ -340,14 +342,14 @@
 		'friendly_name' => __('Working Time', 'reportit'),
 		'method'        => 'spacer',
 	),
-	'id' => array(
+	'id' => [
 		'method' => 'hidden_zero',
 		'value'  => '|arg1:id|',
-	),
-	'tab' => array(
+	],
+	'tab' => [
 		'method' => 'hidden_zero',
 		'value'  => 'presets',
-	),
+	],
 	'start_time' => array(
 		'friendly_name' => __('From', 'reportit'),
 		'description'   => __('The startpoint of duration you want to analyse', 'reportit'),
@@ -407,18 +409,18 @@
 	WHERE group_member.user_id IS NOT NULL OR user_realm.user_id IS NOT NULL';
 
 $form_array_general = array(
-	'id' => array(
+	'id' => [
 		'method' => 'hidden_zero',
 		'value'  => '|arg1:id|',
-	),
-	'tab' => array(
+	],
+	'tab' => [
 		'method' => 'hidden_zero',
 		'value'  => 'general',
-	),
-	'template_id' => array(
+	],
+	'template_id' => [
 		'method' => 'hidden_zero',
 		'value'  => '|arg1:template_id|',
-	),
+	],
 	'header_1' => array(
 		'friendly_name' => __('General', 'reportit'),
 		'method'        => 'spacer',

lib/const_rrdlist.php

@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types=1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |
@@ -34,14 +36,14 @@
 	1 => __('Add', 'reportit')
 );
 
-$link_array = array(
+$link_array = [
 	'name_cache',
 	'description',
 	'',
 	'',
 	'timezone',
 	''
-);
+];
 
 // $timezone - array, for dropdown menu
 //           - contains the $keys from $timezones array.
@@ -63,7 +65,7 @@
 
 // $shifttime - array, for dropdown menu
 //            - contains all possible timestamps of a day by using steps of 5 minutes
-$shifttime = array();
+$shifttime = [];
 
 for($i = 0; $i < 24; $i++) {
 	$hour=$i;

lib/const_runtime.php

@@ -1,4 +1,6 @@
 <?php
+
+declare(strict_types=1);
 /*
  +-------------------------------------------------------------------------+
  | Copyright (C) 2004-2026 The Cacti Group                                 |
@@ -30,39 +32,39 @@
 if (!defined('REPORTIT_EXP_FD')) define('REPORTIT_EXP_FD', CACTI_PATH_BASE . '/plugins/reportit/exports/');
 
 $timezones = array(
-	'AEDT (GMT+11 )'  => array('hour' => 11, 'min' =>  0),
-	'ACDT (GMT+10.5)' => array('hour' => 10, 'min' => 30),
-	'AEST (GMT+10 )'  => array('hour' => 10, 'min' =>  0),
-	'ACST (GMT+09.5)' => array('hour' =>  9, 'min' => 30),
-	'JST (GMT+09 )'   => array('hour' =>  9, 'min' =>  0),
-	'ROK (GMT+09 )'   => array('hour' =>  9, 'min' =>  0),
-	'SST (GMT+08 )'   => array('hour' =>  8, 'min' =>  0),
-	'THA (GMT+07 )'   => array('hour' =>  7, 'min' =>  0),
-	'IST (GMT+05.5)'  => array('hour' =>  5, 'min' => 30),
-	'EEST (GMT+03)'   => array('hour' =>  3, 'min' =>  0),
-	'MEST (GMT+02)'   => array('hour' =>  2, 'min' =>  0),
-	'EET (GMT+02)'    => array('hour' =>  2, 'min' =>  0),
-	'CEST (GMT+02)'   => array('hour' =>  2, 'min' =>  0),
-	'BST (GMT+01)'    => array('hour' =>  1, 'min' =>  0),
-	'CET (GMT+01)'    => array('hour' =>  1, 'min' =>  0),
-	'MET (GMT+01)'    => array('hour' =>  1, 'min' =>  0),
-	'WEST (GMT+01)'   => array('hour' =>  1, 'min' =>  0),
-	'GMT'             => array('hour' =>  0, 'min' =>  0),
-	'WET (GMT)'       => array('hour' =>  0, 'min' =>  0),
-	'BDT (GMT-02)'    => array('hour' => -2, 'min' =>  0),
-	'BT (GMT-03)'     => array('hour' => -2, 'min' =>  0),
-	'EDT (GMT-04)'    => array('hour' => -4, 'min' =>  0),
-	'EST (GMT-05)'    => array('hour' => -5, 'min' =>  0),
-	'CDT (GMT-05)'    => array('hour' => -5, 'min' =>  0),
-	'CST (GMT-06)'    => array('hour' => -6, 'min' =>  0),
-	'MDT (GMT-06)'    => array('hour' => -6, 'min' =>  0),
-	'MST (GMT-07)'    => array('hour' => -7, 'min' =>  0),
-	'PDT (GMT-07)'    => array('hour' => -7, 'min' =>  0),
-	'PST (GMT-08)'    => array('hour' => -8, 'min' =>  0)
+	'AEDT (GMT+11 )'  => ['hour' => 11, 'min' =>  0],
+	'ACDT (GMT+10.5)' => ['hour' => 10, 'min' => 30],
+	'AEST (GMT+10 )'  => ['hour' => 10, 'min' =>  0],
+	'ACST (GMT+09.5)' => ['hour' =>  9, 'min' => 30],
+	'JST (GMT+09 )'   => ['hour' =>  9, 'min' =>  0],
+	'ROK (GMT+09 )'   => ['hour' =>  9, 'min' =>  0],
+	'SST (GMT+08 )'   => ['hour' =>  8, 'min' =>  0],
+	'THA (GMT+07 )'   => ['hour' =>  7, 'min' =>  0],
+	'IST (GMT+05.5)'  => ['hour' =>  5, 'min' => 30],
+	'EEST (GMT+03)'   => ['hour' =>  3, 'min' =>  0],
+	'MEST (GMT+02)'   => ['hour' =>  2, 'min' =>  0],
+	'EET (GMT+02)'    => ['hour' =>  2, 'min' =>  0],
+	'CEST (GMT+02)'   => ['hour' =>  2, 'min' =>  0],
+	'BST (GMT+01)'    => ['hour' =>  1, 'min' =>  0],
+	'CET (GMT+01)'    => ['hour' =>  1, 'min' =>  0],
+	'MET (GMT+01)'    => ['hour' =>  1, 'min' =>  0],
+	'WEST (GMT+01)'   => ['hour' =>  1, 'min' =>  0],
+	'GMT'             => ['hour' =>  0, 'min' =>  0],
+	'WET (GMT)'       => ['hour' =>  0, 'min' =>  0],
+	'BDT (GMT-02)'    => ['hour' => -2, 'min' =>  0],
+	'BT (GMT-03)'     => ['hour' => -2, 'min' =>  0],
+	'EDT (GMT-04)'    => ['hour' => -4, 'min' =>  0],
+	'EST (GMT-05)'    => ['hour' => -5, 'min' =>  0],
+	'CDT (GMT-05)'    => ['hour' => -5, 'min' =>  0],
+	'CST (GMT-06)'    => ['hour' => -6, 'min' =>  0],
+	'MDT (GMT-06)'    => ['hour' => -6, 'min' =>  0],
+	'MST (GMT-07)'    => ['hour' => -7, 'min' =>  0],
+	'PDT (GMT-07)'    => ['hour' => -7, 'min' =>  0],
+	'PST (GMT-08)'    => ['hour' => -8, 'min' =>  0]
 );
 
 
-$runtime_messages = array(
+$runtime_messages = [
 	1 => 'ERROR: PHP module for RRDtool is not available.',
 	2 => 'ERROR: No data items defined. RIReport[<RID>]',
 	3 => 'ERROR: Startpoint is a part of future. RIReport[<RID>] RIDataItem[<DID>]',
@@ -80,5 +82,5 @@
 	15 => 'WARNING: <NOTICE>',
 	16 => 'NOTICE: <NOTICE>',
 	17 => 'ERROR: <NOTICE>'
-);
+];