-
Notifications
You must be signed in to change notification settings - Fork 18
Modelling: On LSB open the horizontal scrollbar moves the scrollbar #3672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modelling: On LSB open the horizontal scrollbar moves the scrollbar #3672
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses horizontal scrollbar positioning issues when the LSB (Left Side Bar) is open by implementing comprehensive responsive design updates. The changes focus on dynamically adjusting table heights based on screen dimensions and LSB state to prevent layout conflicts.
- Modified existing responsive breakpoint for medium screens (700-800px height)
- Added extensive LSB-aware styling with complex selector targeting
- Implemented container queries for additional responsive behavior
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
[+] Added <div> wrapper around button in NetworkModelling.razor to avoid that the button extends to 100% width [~] Updated .connectiontable-responsive styles for better height management in ConnectionTable.razor.css [~] Improved flexbox layout for tabs in TabSet.razor.css to make the new responsive changes work CactuseSecurity#3659
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@tpurschke |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good
[ + ] Added div wrapper around button in NetworkModelling.razor to avoid that the button extends to 100% width because of the css
[ ~ ] Updated .connectiontable-responsive styles for better height management in ConnectionTable.razor.css
[ ~ ] Improved flexbox layout for tabs in TabSet.razor.css to make the new responsive changes work
Closing #3659 (Maybe needs structure rework)