Skip to content

Conversation

SolidProgramming
Copy link
Contributor

@SolidProgramming SolidProgramming commented Sep 5, 2025

[ + ] Added div wrapper around button in NetworkModelling.razor to avoid that the button extends to 100% width because of the css
[ ~ ] Updated .connectiontable-responsive styles for better height management in ConnectionTable.razor.css
[ ~ ] Improved flexbox layout for tabs in TabSet.razor.css to make the new responsive changes work

Closing #3659 (Maybe needs structure rework)

@SolidProgramming SolidProgramming self-assigned this Sep 5, 2025
Copy link

sonarqubecloud bot commented Sep 5, 2025

@SolidProgramming SolidProgramming marked this pull request as ready for review September 5, 2025 17:13
Copilot

This comment was marked as outdated.

@SolidProgramming SolidProgramming marked this pull request as draft September 5, 2025 17:15
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses horizontal scrollbar positioning issues when the LSB (Left Side Bar) is open by implementing comprehensive responsive design updates. The changes focus on dynamically adjusting table heights based on screen dimensions and LSB state to prevent layout conflicts.

  • Modified existing responsive breakpoint for medium screens (700-800px height)
  • Added extensive LSB-aware styling with complex selector targeting
  • Implemented container queries for additional responsive behavior

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

SolidProgramming and others added 3 commits September 8, 2025 08:51
[+] Added <div> wrapper around button in NetworkModelling.razor to avoid that the button extends to 100% width
[~] Updated .connectiontable-responsive styles for better height management in ConnectionTable.razor.css
[~] Improved flexbox layout for tabs in TabSet.razor.css to make the new responsive changes work CactuseSecurity#3659
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SolidProgramming SolidProgramming marked this pull request as ready for review September 14, 2025 14:42
Copy link

@SolidProgramming
Copy link
Contributor Author

SolidProgramming commented Sep 16, 2025

@tpurschke
I tested the changes on a new install, and they work better than the old implementation. But still, if the view of the right side gets to small the structure breaks and shifts some elements together/down. The connection table/tabset element should be fine now. The problem with elements shifting down is, that the style of the "connectiontable-responsive" class has currently a calculated height "calc(100vh - 430px);". If elements shift down, the value "430px" doesn't work anymore. I guess this could be fixed with calculating the height value with JavaScript of all elements above(navbar/buttons/apps/labels) and adjusting the style's height, but i don't know JS good enough to be confident that it will fix our problem...

Copy link
Contributor

@tpurschke tpurschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

@tpurschke tpurschke merged commit 2ee4c48 into CactuseSecurity:develop Sep 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants