Fixes water color with zero-alpha being invisible on neoforge with terralith#3577
Open
douira wants to merge 1 commit intoCaffeineMC:devfrom
Open
Fixes water color with zero-alpha being invisible on neoforge with terralith#3577douira wants to merge 1 commit intoCaffeineMC:devfrom
douira wants to merge 1 commit intoCaffeineMC:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the 26.1 port this code changed to use a different path because it seems getTint was removed from the neoforge class, but the new tint source code doesn't properly do masking.
For comparison, the fabric variant of this code has the appropriate masking.
Fixes #3576
@IMS212 please review whether this is the correct location for this masking. You're the code owner here so I don't know what should go where.