Update README.md#623
Open
judithJn wants to merge 2 commits into
Open
Conversation
Closes CalloraOrg#413, Closes CalloraOrg#426. Issue CalloraOrg#426 - contracts/revenue_pool/src/test_reentrancy.rs: - Add MaliciousToken mock whose transfer() callback re-enters the revenue pool under attacker-controlled configuration. - Five tests covering distribute, batch_distribute, set_admin, and pause analogues (mapped to in-tree execute/propose/cancel_ emergency_drain while distribute/batch_distribute/pause are mid- refactor): each vector asserts post-call state is consistent and no malicious re-entry succeeded. - Real-callback disarm test proves the mock disarms end-to-end. - pub mod emergency wired up in lib.rs so cross-crate tests can decode PendingEmergencyDrain directly. Issue CalloraOrg#413 - tests/event_schema_audit.rs + EVENT_SCHEMA.md: - Cross-contract event-schema conformance audit harness: five tests, including strict short-form set_admin conformance lock and renamed byte-identity gate that comments the layered coverage. - EVENT_SCHEMA.md adds a follow-up change-note plus an Open Reconciliation Items table enumerating every schema/code drift. - SECURITY.md gains a Revenue Pool Reentrancy Mitigation section enumerating the four attack vectors and the post-conditions each test asserts.
|
@judithJn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #413
Closes #426