Move KeypressDialogWidget to FrontEndLib#1104
Merged
Hypexion merged 2 commits intoCaravelGames:masterfrom Apr 7, 2026
Merged
Conversation
Hypexion
force-pushed
the
converge-keypress-widgets
branch
from
fb981ae to
fe0d953
Compare
Hypexion
force-pushed
the
converge-keypress-widgets
branch
from
fe0d953 to
8787300
Compare
mrimer
reviewed
Apr 7, 2026
| { | ||
| public: | ||
| CKeypressDialogWidget(UINT dwSetTagNo); | ||
| CKeypressDialogWidget(UINT dwSetTagNo, WSTRING wstrGetKeyText, |
Member
There was a problem hiding this comment.
Suggest "const &" on these WSTRINGS (as general practice for non-primitive input params).
mrimer
approved these changes
Apr 7, 2026
Member
mrimer
left a comment
mrimer
left a comment
There was a problem hiding this comment.
Thank you! Feel free to merge at your convenience.
Collaborator
|
Checked, no comments from me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since TSS 5.2 and RPG 2 were developed on separate branches, we ended up duplicating the files for
KeypressDialogWidget. Now that everything's been merged back, we should replace the two game-specific implementations with a single common implementation in FrontEndLib.The main changes were clearing up the use of
g_pTheDB, which we don't want to be doing in FrontEndLib. I also addedF_Headerto the list of fonts inFontManager.h, as it's used in the widget.