A0-0000 Fixed performance e2e flakiness#1963
Merged
Marcin-Radecki merged 1 commit intomainfrom Mar 27, 2025
Merged
Conversation
mike1729
approved these changes
Mar 27, 2025
Contributor
mike1729
left a comment
mike1729
left a comment
There was a problem hiding this comment.
One nit, feel free to ignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The way
one_validator_is_deadis written now, it's disabling both AURA and Aleph keys. Since default production ban config threshold is 3, sometimes we kicked disabled node from the committee which then resulted in perfect score, hence test failed. This PR fixes that by extending production ban config threshold so that kick does not happen.There's tiny bug in the test which does not influence test run - it printed out wrong account id to std out. Also, I decreased waiting time here and there so both performance tests should run faster now (around 3 minutes).
Type of change
Please delete options that are not relevant.
Testing