Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
jalooc
reviewed
May 26, 2025
| relayerUrl: string, | ||
| }, | ||
| urlPathSegment: string, | ||
| disabled?: boolean, |
Contributor
There was a problem hiding this comment.
I think it'd be better to construct ChainConfig so that it's possible to not define either testnet or mainnet, instead of "pretending" to define them by providing deficient data and not even use them anywhere.
ae79e50 to
7a82d0c
Compare
7a82d0c to
2a174e5
Compare
2a174e5 to
2122af3
Compare
2122af3 to
e8bef83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.