Skip to content

SD-95: Add base sepolia#81

Merged
rAskVAL merged 1 commit intomainfrom
sd-95-add-base-on-testnet
May 27, 2025
Merged

SD-95: Add base sepolia#81
rAskVAL merged 1 commit intomainfrom
sd-95-add-base-on-testnet

Conversation

@rAskVAL
Copy link
Contributor

@rAskVAL rAskVAL commented May 22, 2025

No description provided.

@aws-amplify-eu-central-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-81.d1rxgx3w89g7ku.amplifyapp.com

relayerUrl: string,
},
urlPathSegment: string,
disabled?: boolean,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be better to construct ChainConfig so that it's possible to not define either testnet or mainnet, instead of "pretending" to define them by providing deficient data and not even use them anywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure will check

@rAskVAL rAskVAL force-pushed the sd-95-add-base-on-testnet branch from ae79e50 to 7a82d0c Compare May 27, 2025 10:17
@rAskVAL rAskVAL requested a review from jalooc May 27, 2025 10:17
Copy link
Contributor

@jalooc jalooc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@rAskVAL rAskVAL force-pushed the sd-95-add-base-on-testnet branch from 2122af3 to e8bef83 Compare May 27, 2025 12:12
@rAskVAL rAskVAL merged commit 1f510e1 into main May 27, 2025
6 checks passed
@rAskVAL rAskVAL deleted the sd-95-add-base-on-testnet branch May 27, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants