[#123] Enhance ActivityNotificationJob with null-safety, deprecated API fix, and summary logging #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #123 by improving the ActivityNotificationJob class. The focus is on fixing potential runtime issues and adding lightweight improvements for better reliability and transparency.
Fixes
Added null-safety checks to prevent NullPointerException when ApplicationUser, coordinators, or admins are missing or do not have an email address.
Replaced the deprecated user.getName() call with user.getUsername() to align with the current Jira API.
Enhancements
Added summary logging at the end of execution to show how many inactive and offline users were notified.
Added warning logs when coordinators or admins are missing or lack valid email addresses.
Benefits
Reduces the risk of runtime failures during scheduled job execution.
Provides clearer and more transparent logs for administrators to understand who was notified.
Ensures the code is more future-proof and compatible with newer Jira API versions.